Skip to content

LLVM: Move aliases to aliases.nix and switch to llvmPackages_latest#118076

Closed
primeos wants to merge 2 commits intoNixOS:masterfrom
primeos:llvm-move-aliases
Closed

LLVM: Move aliases to aliases.nix and switch to llvmPackages_latest#118076
primeos wants to merge 2 commits intoNixOS:masterfrom
primeos:llvm-move-aliases

Conversation

@primeos
Copy link
Member

@primeos primeos commented Mar 30, 2021

Motivation for this change

See #116736 (comment).

Unfortunately clang and llvm (s. "TODO" in the diff) are used to widely so moving those attributes requires someone who knows how to do mass renames (via rnix-parser, etc.).

E.g. this is still very inconsistent (mixing llvmPackages and llvmPackages_latest):

  clang = llvmPackages.clang;
  clang-manpages = llvmPackages.clang-manpages;
  clang-tools = callPackage ../development/tools/clang-tools {
    llvmPackages = llvmPackages_latest;
  };
  clang-analyzer = callPackage ../development/tools/analysis/clang-analyzer {
    llvmPackages = llvmPackages_latest;
    inherit (llvmPackages_latest) clang;
  };
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@primeos primeos requested review from FRidh and jonringer as code owners March 30, 2021 14:51
@github-actions github-actions bot added 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. 6.topic: python Python is a high-level, general-purpose programming language. labels Mar 30, 2021

gringo = callPackage ../tools/misc/gringo { };
gringo = callPackage ../tools/misc/gringo {
inherit (pkgs.llvmPackages) libcxx;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could also be done for discord.

Copy link
Member Author

@primeos primeos Mar 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I considered that but I'm not sure if it's worth it as discord/base.nix is called indirectly through discord/default.nix (and that way it's implemented might make this a bit tricky but it should be doable if necessary).

Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@primeos
Copy link
Member Author

primeos commented Jun 16, 2021

I'll drop this, not sure anymore if this is even a good idea (it would avoid some issues but likely also introduce new ones like making it harder to discover these aliases).

@primeos primeos closed this Jun 16, 2021
@rrbutani rrbutani added the 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. 6.topic: python Python is a high-level, general-purpose programming language.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants