LLVM: Move aliases to aliases.nix and switch to llvmPackages_latest#118076
Closed
primeos wants to merge 2 commits intoNixOS:masterfrom
Closed
LLVM: Move aliases to aliases.nix and switch to llvmPackages_latest#118076primeos wants to merge 2 commits intoNixOS:masterfrom
primeos wants to merge 2 commits intoNixOS:masterfrom
Conversation
10 tasks
|
|
||
| gringo = callPackage ../tools/misc/gringo { }; | ||
| gringo = callPackage ../tools/misc/gringo { | ||
| inherit (pkgs.llvmPackages) libcxx; |
Member
There was a problem hiding this comment.
This could also be done for discord.
Member
Author
There was a problem hiding this comment.
Yes, I considered that but I'm not sure if it's worth it as discord/base.nix is called indirectly through discord/default.nix (and that way it's implemented might make this a bit tricky but it should be doable if necessary).
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
Member
Author
|
I'll drop this, not sure anymore if this is even a good idea (it would avoid some issues but likely also introduce new ones like making it harder to discover these aliases). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
See #116736 (comment).
Unfortunately
clangandllvm(s. "TODO" in the diff) are used to widely so moving those attributes requires someone who knows how to do mass renames (viarnix-parser, etc.).E.g. this is still very inconsistent (mixing
llvmPackagesandllvmPackages_latest):Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)