md2gemini: init at 1.8.1#117917
Conversation
pkgs/top-level/python-packages.nix
Outdated
There was a problem hiding this comment.
I think it would be clearer if we converted the current default into a generic nix and created a 0.8.nix and a 2.nix file.
There was a problem hiding this comment.
Did it same way as postgresql do.
There was a problem hiding this comment.
| propagatedBuildInputs = [ mistune_2 cjkwrap wcwidth ]; | |
| checkInputs = [ pytest ]; |
There was a problem hiding this comment.
| { lib, buildPythonPackage, fetchPypi, mistune_2, cjkwrap, wcwidth, pytest }: | |
| { lib, buildPythonPackage, fetchPypi, mistune_2, cjkwrap, wcwidth, pytestCheckHook }: |
pkgs/top-level/all-packages.nix
Outdated
There was a problem hiding this comment.
That causes an eval error.
There was a problem hiding this comment.
That does not belong here, removed.
|
Looks like I applied all suggestions. |
|
@ofborg eval |
|
Okay, now @ofborg is happy. |
There was a problem hiding this comment.
It was this way before.
|
Okay, I added pythonImportsCheck to mistune, but I'd rather not assume maintainership of every indirect dependency I touch. Wh |
The problem is that if your dependencies are not maintained they are potentially in a worse state but it seems like mistune is used in a lot more packages. I think adding the imports check to mistune triggered the mass rebuild. We really want to have one if there are not tests because otherwise the package can silently break. I think the best solution would be to merge this PR into staging because if we split the change out we force a merge conflict which someone would need to resolve. Let me know if thats a problem for you. |
SuperSandro2000
left a comment
There was a problem hiding this comment.
other than that the ordering could be a bit more standard LGTM if rebased to staging
SuperSandro2000
left a comment
There was a problem hiding this comment.
other than that the ordering could be a bit more standard LGTM if rebased to staging
|
Yes, sure. Let's merge it into staging. |
|
/rebase staging |
2cdc2b4 to
0cb7479
Compare
|
Rebased, please reopen the pull request to restart CI |
This version is required for md2gemini program and is incompatible with mistune=0.8.4
0cb7479 to
403481c
Compare
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)