Skip to content

nixos/metricbeat: init#117379

Merged
roberth merged 1 commit intoNixOS:masterfrom
hercules-ci:nixos-metricbeat
Jun 8, 2021
Merged

nixos/metricbeat: init#117379
roberth merged 1 commit intoNixOS:masterfrom
hercules-ci:nixos-metricbeat

Conversation

@roberth
Copy link
Member

@roberth roberth commented Mar 23, 2021 •
edited
Loading

Motivation for this change

Add a module for metricbeat, the metric shipper for the ELK stack.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Mar 23, 2021
@ofborg ofborg bot requested review from basvandijk, offlinehacker and wjlroe March 23, 2021 17:04
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 23, 2021
fogti
fogti reviewed Mar 23, 2021
View reviewed changes
@ofborg ofborg bot removed the request for review from wjlroe March 23, 2021 18:37
@NixOS NixOS deleted a comment from r-rmcgibbo Mar 31, 2021
@roberth
Copy link
Member Author

roberth commented Mar 31, 2021 •
edited
Loading

@GrahamcOfBorg build metricbeat

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. and removed 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Mar 31, 2021
@nixos-discourse
Copy link

nixos-discourse commented May 3, 2021

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/513

@nixos-discourse
Copy link

nixos-discourse commented May 25, 2021

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/535

@roberth roberth force-pushed the nixos-metricbeat branch from 4c005b9 to 50a08f3 Compare May 31, 2021 08:39
@roberth roberth force-pushed the nixos-metricbeat branch from 50a08f3 to 5699d02 Compare May 31, 2021 08:42
@roberth
Copy link
Member Author

roberth commented May 31, 2021

cc elasticsearch maintainers @apeschar @basvandijk. Could you please review this "ES-ecosystem" pr?

@ofborg ofborg bot removed the 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. label May 31, 2021
fogti
fogti reviewed May 31, 2021
View reviewed changes
nixos/modules/services/monitoring/metricbeat.nix
-c ${settingsFormat.generate "metricbeat.yml" cfg.settings} \
--path.data $STATE_DIRECTORY \
--path.logs $LOGS_DIRECTORY \
;
Copy link
Contributor

@fogti fogti May 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the semicolon needed for?

Copy link
Member Author

@roberth roberth Jun 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's for the backslash. This style of multi-line statement produces smaller diffs, making it easier to merge.

@roberth
Copy link
Member Author

roberth commented Jun 8, 2021

I was hoping for more feedback or an approval, but I've already called attention to this PR a number of times. It's time to move this forward. If anyone has improvements, I can implement them after the merge as well.

Thank you @zseri for your comments.

@roberth roberth merged commit 843248d into NixOS:master Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

@basvandijk basvandijk Awaiting requested review from basvandijk

1 more reviewer

@fogti fogti fogti left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@roberth @nixos-discourse @fogti