gnutls: Fix failing patch when cross compiling to Arm32#117279
Closed
matthewmazzanti wants to merge 2 commits intoNixOS:masterfrom
Closed
gnutls: Fix failing patch when cross compiling to Arm32#117279matthewmazzanti wants to merge 2 commits intoNixOS:masterfrom
matthewmazzanti wants to merge 2 commits intoNixOS:masterfrom
Conversation
A patch for tests that fail on arm has been upstreamed, and is no longer needed. I have gated this behind a lib.versionOlder to allow the build.
10 tasks
Member
|
The patch wasn't failing (I first thought you meant that) but perhaps it isn't needed anymore. The cross-compilation I tried works both before and after this PR.
|
Member
|
With gnutls 3.7.1 the patch no longer applied and was removed in #119590 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
A patch for tests that fail on arm has been upstreamed, and is no longer needed.
Things done
Remove the patch
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)