openssh: Fix cross-compile regression from c99c499#117053
openssh: Fix cross-compile regression from c99c499#117053SuperSandro2000 merged 2 commits intoNixOS:staging-nextfrom
Conversation
matthewmazzanti
changed the title
ofborg
bot
added
10.rebuild-darwin: 0
There was a problem hiding this comment.
| # pacakge without splicing See: https://github.com/NixOS/nixpkgs/pull/107606 | |
| # package without splicing See: https://github.com/NixOS/nixpkgs/pull/107606 |
Good idea to add a comment. Could we use target or buildPackages to make it even clearer?
There was a problem hiding this comment.
Sure - I replicated what was there before since that was "known good" and the original PR mentioned it was a correct use-case, but I'll give it a shot with buildPackages
There was a problem hiding this comment.
Running with "buildPackages" instead of "pkgs" fails with the same error as the unpatched version. I'll admit that I'm new to the whole cross compiling on nix business, so I don't quite understand why.
There was a problem hiding this comment.
mmm. I think this fix is fine for now and we maybe investigate that later.
|
/rebase staging-next |
Recent refactoring from c99c499 into a "common.nix" dropped some unusual details that allowed cross-compilation. This patch reinstates those, and adds comments for posterity linking to cross compilation discussion.
github-actions
bot
force-pushed
the
fix-openssh-cross
branch
from
6270890 to
97d662c
Compare
|
Rebased, please reopen the pull request to restart CI |
|
openssh/openssh-portable@32dd2da the underlying issue is now fixed, so we can depend on kerberos normally next release. |
3 participants
Motivation for this change
Recent refactoring from c99c499 into a "common.nix" dropped some unusual details that allowed cross-compilation. See #107606 for more details on the original patch.
Things done
This patch reinstates those, and adds comments for posterity linking to cross compilation discussion.
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)