Skip to content

dzen2: add the dzen2 application#1169

Closed
sergei-mironov wants to merge 1 commit intoNixOS:masterfrom
sergei-mironov:dzen2
Closed

dzen2: add the dzen2 application#1169
sergei-mironov wants to merge 1 commit intoNixOS:masterfrom
sergei-mironov:dzen2

Conversation

@sergei-mironov
Copy link
Contributor

Support for xinerama and xpm are enabled

Support for xinerama and xpm are enabled
@7c6f434c
Copy link
Member

7c6f434c commented Nov 7, 2013

Do you really need a fully hand-written builder here?

@sergei-mironov
Copy link
Contributor Author

I've reviewed the expression. Looks like it is one of the first I've ever wrote. Certainly, some things could be simpler: config file may be generated with writeText instead of sedding the patch. Still, the hand-written builder seems to be necessary because we have to build and install not only the main directory, but the gadgets directory as well (see sergei-mironov@5d396d8#diff-4014cccf7f97c40e7a4d27bf3a3c253aR27).

@7c6f434c
Copy link
Member

I would:

— use sed -i with multiple files to edit config.mk in both places and call it "configurePhase"

— run make -C gadgets in postBuild

— run ``make -C gadgets install` in postInstall

And set these actions inside the main expression. I think it would make the expression simpler…

@drvirgilio
Copy link
Contributor

Unaware of this pull request, I made my own expression and pull request here: #1386
This issue should be closed.

@sergei-mironov
Copy link
Contributor Author

Thanks! Looks like I'm rather slow in maintaining this one ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants