Skip to content

python3Packages.luftdaten: 0.6.4 -> 0.6.5#116620

Merged
fabaff merged 1 commit intoNixOS:masterfrom
dotlambda:luftdaten-0.6.6
Mar 20, 2021
Merged

python3Packages.luftdaten: 0.6.4 -> 0.6.5#116620
fabaff merged 1 commit intoNixOS:masterfrom
dotlambda:luftdaten-0.6.6

Conversation

@dotlambda
Copy link
Member

Motivation for this change

depends on #115435

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dotlambda dotlambda requested a review from fabaff March 17, 2021 12:38
@ofborg ofborg bot added 6.topic: python Python is a high-level, general-purpose programming language. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 17, 2021
@dotlambda dotlambda marked this pull request as ready for review March 19, 2021 19:35
@fabaff
Copy link
Member

fabaff commented Mar 20, 2021

Result of nixpkgs-review pr 116620 run on x86_64-linux 1

2 packages built:
  • python38Packages.luftdaten
  • python39Packages.luftdaten

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • package built (see #116620 (comment))
  • all depending packages build
  • tested on x86_64
...ew/pr-116620/results/python38Packages.luftdaten/lib/python3.8/site-packages]$ python
Python 3.8.8 (default, Feb 19 2021, 11:04:50) 
[GCC 10.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import luftdaten, aiohttp, asyncio
>>> async def main():
...     async with aiohttp.ClientSession() as session:
...         data = luftdaten.Luftdaten(155, loop, session)
...         await data.get_data()
...         print(data.values)
... 
>>> loop = asyncio.get_event_loop()
>>> loop.run_until_complete(main())
{}

Update looks good to me.

@fabaff fabaff merged commit 7d99b46 into NixOS:master Mar 20, 2021
@dotlambda dotlambda deleted the luftdaten-0.6.6 branch March 20, 2021 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants