Skip to content

Comments

sage: remove duplicated pkgconfig#116594

Merged
SuperSandro2000 merged 1 commit intomasterfrom
SuperSandro2000-patch-1
Mar 17, 2021
Merged

sage: remove duplicated pkgconfig#116594
SuperSandro2000 merged 1 commit intomasterfrom
SuperSandro2000-patch-1

Conversation

@SuperSandro2000
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 17, 2021
@SuperSandro2000 SuperSandro2000 merged commit fe4a249 into master Mar 17, 2021
@SuperSandro2000 SuperSandro2000 deleted the SuperSandro2000-patch-1 branch March 17, 2021 10:10
@collares
Copy link
Member

collares commented Mar 20, 2021

This broke sage (build logs, but note that this also failed on ofBorg before you committed it). The pkgconfig you removed lives at pkgs/development/python-modules/pkgconfig, it's not the alias to pkg-config. Please tag the sage maintainers on sage changes.

cc @omasanori @timokau @7c6f434c

@collares
Copy link
Member

By the way, the commit that added the "duplicated" pkg-config line explicitly says that sage breaks without it: d2c4b57

@collares collares mentioned this pull request Jan 10, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants