quodlibet: update to version 2.6.3

[coroa]

also provides two distinctive flavours, which either wrap the program to
pull in the gstreamer plugins or not.

[bjornfor]

(Oops, I deleted my comment.) Should there be an assert here to ensure that plugins are != null if wrapForGSTPlugins is true?

[coroa]

i didn't add one, so that you can also choose to build quodlibet with just gst_plugins_base and w/o gst_plugins_{good,ugly}.

i could add an assert for at least one being available. shall i?

[bjornfor]

If that's the intention I don't think an assert is needed. But I guess the "at least one" assert is kind of nice. You choose! :-)

[bjornfor]

@coroa: What is the purpose of the unwrapped variant? Don't you need gst plugins to play music?

[Phreedom]

unwrapped variant works in nixos, and I'd say is preferable for nixos. wrapped
one is much easier to run for a nixpkgs-only user

[bjornfor]

@Phreedom: Why is the unwrapped preferred on nixos? Just so that you can add/remove gst plugins without rebuilding the app? (Just trying to understand.)

[coroa]

@bjornfor: nixos takes care of adding gst_plugins_* to a global GST_PLUGIN_PATH environment variable. this way you can choose, which plugins are available by just adding them to your environment.

[bjornfor]

I get eval error:

$ nix-env -f . -qa '*' --meta --xml --drv-path --show-trace
error: while evaluating the attribute `postInstall' of the derivation `quodlibet-2.6.3-with-gst-plugins' at `/home/bfo/nixpkgs2/pkgs/development/python-modules/generic/default.nix:51:3':
while evaluating `optionalString' at `/home/bfo/nixpkgs2/lib/strings.nix:55:26':
while evaluating `concatStringsSep' at `/home/bfo/nixpkgs2/lib/strings.nix:33:33':
while evaluating `fold' at `/home/bfo/nixpkgs2/lib/lists.nix:24:19':
while evaluating `fold'' at `/home/bfo/nixpkgs2/lib/lists.nix:27:15':
while evaluating an anonymous function at `/home/bfo/nixpkgs2/lib/strings.nix:14:32':
while evaluating `fold'' at `/home/bfo/nixpkgs2/lib/lists.nix:27:15':
while evaluating an anonymous function at `/home/bfo/nixpkgs2/lib/strings.nix:14:32':
while evaluating `fold'' at `/home/bfo/nixpkgs2/lib/lists.nix:27:15':
while evaluating an anonymous function at `/home/bfo/nixpkgs2/lib/strings.nix:14:32':
while evaluating `fold'' at `/home/bfo/nixpkgs2/lib/lists.nix:27:15':
while evaluating an anonymous function at `/home/bfo/nixpkgs2/lib/strings.nix:14:32':
while evaluating `fold'' at `/home/bfo/nixpkgs2/lib/lists.nix:27:15':
while evaluating an anonymous function at `/home/bfo/nixpkgs2/lib/strings.nix:14:32':
while evaluating `fold'' at `/home/bfo/nixpkgs2/lib/lists.nix:27:15':
while evaluating an anonymous function at `/home/bfo/nixpkgs2/lib/strings.nix:14:32':
while evaluating `fold'' at `/home/bfo/nixpkgs2/lib/lists.nix:27:15':
while evaluating an anonymous function at `/home/bfo/nixpkgs2/lib/strings.nix:14:32':
while evaluating an anonymous function at `/home/bfo/nixpkgs2/pkgs/applications/audio/quodlibet/default.nix:53:16':
cannot coerce a boolean to a string

Line 53 is map (s: s + "/lib/gstreamer-0.10") from this block:

      ${ stdenv.lib.concatStringsSep ":"
         (map (s: s + "/lib/gstreamer-0.10")
           (stdenv.lib.filter (s: s != null) [
             gst_plugins_base gst_plugins_good gst_plugins_ugly gst_plugins_bad
           ])) }

I don't understand why nix sees the types as booleans, I thought they were packages/paths/strings.

[coroa]

sorry, i'm at fault, for adding gst_plugins_bad and setting them to false in all-packages.nix instead of null. memo to self: always do a nix-build before pushing :P

[bjornfor]

You can also do nix-env -f . -qa '*' --meta --xml --drv-path --show-trace before pushing. That command will tell you if maintainer or license attributes are misspelled (which nix-build does not catch).

Pushed to master. Thanks!