gnvim: fix install phase with Rust with custom target#115267
Merged
teto merged 1 commit intoNixOS:masterfrom Mar 6, 2021
Merged
gnvim: fix install phase with Rust with custom target#115267teto merged 1 commit intoNixOS:masterfrom
teto merged 1 commit intoNixOS:masterfrom
Conversation
SuperSandro2000
requested changes
Mar 6, 2021
38ad11a to
ec5fb3c
Compare
Member
Author
|
@ofborg build gnvim |
Member
it took a while but build passes locally. Binary works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
When building with
cargo build --release --target <arch> ..., Rust installs the gnvim binary in./taget/<arch>/releaseinstead of./target/release, which isn't taken into account by upstream'sMakefile.Normally, the project would have been compiled by using
make build, but if I understood it correctly, thebuildPhaseis now overridden by the new hook system (#112804)Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)