Skip to content

python3Packages.py-cpuinfo: fix another aarch64-darwin test#115221

Merged
SuperSandro2000 merged 1 commit intoNixOS:stagingfrom
bobrik:ivan/py-cpuinfo-aarch64-darwin-again
Mar 6, 2021
Merged

python3Packages.py-cpuinfo: fix another aarch64-darwin test#115221
SuperSandro2000 merged 1 commit intoNixOS:stagingfrom
bobrik:ivan/py-cpuinfo-aarch64-darwin-again

Conversation

@bobrik
Copy link
Contributor

@bobrik bobrik commented Mar 6, 2021

Motivation for this change

See also: #115220. This helps #105026.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS (aarch64)
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bobrik bobrik requested review from FRidh and jonringer as code owners March 6, 2021 01:51
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Mar 6, 2021
@bobrik bobrik mentioned this pull request Mar 6, 2021
Merged
10 tasks
@mweinelt
Copy link
Member

mweinelt commented Mar 6, 2021

Any particular reason why you didn't put both into the same merge request?

@ofborg ofborg bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Mar 6, 2021
@ofborg ofborg bot requested a review from costrouc March 6, 2021 02:00
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Mar 6, 2021
@SuperSandro2000 SuperSandro2000 merged commit f8441c6 into NixOS:staging Mar 6, 2021
@bobrik bobrik deleted the ivan/py-cpuinfo-aarch64-darwin-again branch March 6, 2021 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@costrouc costrouc Awaiting requested review from costrouc

Assignees

No one assigned

Labels

6.topic: darwin Running or building packages on Darwin 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bobrik @mweinelt @SuperSandro2000