Skip to content

catgirl: init at 1.6#115159

Merged
SuperSandro2000 merged 2 commits intoNixOS:masterfrom
xfnw:master
Mar 27, 2021
Merged

catgirl: init at 1.6#115159
SuperSandro2000 merged 2 commits intoNixOS:masterfrom
xfnw:master

Conversation

@xfnw
Copy link
Member

@xfnw xfnw commented Mar 5, 2021

Motivation for this change

package the catgirl irc client

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@xfnw
Copy link
Member Author

xfnw commented Mar 5, 2021

oops, forgot to add myself to the maintainers list

fixed

@xfnw xfnw force-pushed the master branch 2 times, most recently from 28097cc to 1e38c3b Compare March 5, 2021 03:05
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Mar 5, 2021
@xfnw xfnw requested a review from fabaff March 5, 2021 11:27
@fabaff
Copy link
Member

fabaff commented Mar 5, 2021

Result of nixpkgs-review pr 115159 run on x86_64-linux 1

1 package built:
  • catgirl

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please squash the catgirl: init at 1.6 commits.

@fogti
Copy link
Contributor

fogti commented Mar 6, 2021

It might be a good idea to sort the package lists (e.g. argument list in the header, nativeBuildInputs, buildInputs) alphabetically.

@xfnw
Copy link
Member Author

xfnw commented Mar 16, 2021

It might be a good idea to sort the package lists (e.g. argument list in the header, nativeBuildInputs, buildInputs) alphabetically.

@zseri hmm, i can't seem to find any other packages that sort the build inputs, is that a normal thing to do?

@fogti
Copy link
Contributor

fogti commented Mar 16, 2021

The last few PRs that I reviewed all had sorted build inputs, and I think it is a normal thing to do.
This does not apply to the argument list in the header: it is often not "simply" sorted, and there exist multiple conflicting conventions applied to different packages in nixpkgs.

@xfnw
Copy link
Member Author

xfnw commented Mar 24, 2021

@SuperSandro2000 could you re-review?

Copy link
Contributor

@fogti fogti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

builds successfully with Nix (2.3.10) on Gentoo.

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than that LGTM

@xfnw xfnw requested review from FRidh and jonringer as code owners March 26, 2021 20:54
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Mar 26, 2021
@github-actions github-actions bot removed the 6.topic: python Python is a high-level, general-purpose programming language. label Mar 26, 2021
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Mar 26, 2021
@github-actions github-actions bot removed the 6.topic: python Python is a high-level, general-purpose programming language. label Mar 26, 2021
@SuperSandro2000 SuperSandro2000 merged commit b37b2f3 into NixOS:master Mar 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants