Skip to content

Comments

darwin.bootstrap_cmds: use correct arch in "mig"#114944

Merged
SuperSandro2000 merged 1 commit intoNixOS:stagingfrom
thefloweringash:darwin-arch-fixup
Mar 3, 2021
Merged

darwin.bootstrap_cmds: use correct arch in "mig"#114944
SuperSandro2000 merged 1 commit intoNixOS:stagingfrom
thefloweringash:darwin-arch-fixup

Conversation

@thefloweringash
Copy link
Member

@thefloweringash thefloweringash commented Mar 3, 2021 •
edited
Loading

Motivation for this change

Fix darwin stdenv in staging after breaking it in #114817

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@thefloweringash thefloweringash mentioned this pull request Mar 3, 2021
Merged
10 tasks
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Mar 3, 2021

@ofborg eval

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Mar 3, 2021
@SuperSandro2000 SuperSandro2000 merged commit b29295d into NixOS:staging Mar 3, 2021
@thefloweringash thefloweringash deleted the darwin-arch-fixup branch March 4, 2021 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@bobrik bobrik bobrik approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thefloweringash @SuperSandro2000 @bobrik