Skip to content

Adding KVIrc : a IRC Client for Qt and KDE. in kde4.kvirc#1146

Merged
cillianderoiste merged 3 commits intoNixOS:masterfrom
Chaddai:master
Oct 30, 2013
Merged

Adding KVIrc : a IRC Client for Qt and KDE. in kde4.kvirc#1146
cillianderoiste merged 3 commits intoNixOS:masterfrom
Chaddai:master

Conversation

@Chaddai
Copy link
Contributor

@Chaddai Chaddai commented Oct 29, 2013

Hello,
NixPkgs already has some irc clients (though Konversation is the only Qt one) but KVIrc is pretty good, fast, with advanced features, customizable and easy to build with the current NixPkgs. So why not, just one more option.

@Chaddai
Copy link
Contributor Author

Chaddai commented Oct 29, 2013

Note that it is also pretty stable, so it should not require too much attention. ;-)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor thing: it's better to use the relevant entry from stdenv.lib.licences here.

@Chaddai
Copy link
Contributor Author

Chaddai commented Oct 30, 2013

Ok, I just took examples from some other irc clients though I wondered about the with stdenv.lib.platforms when there already was a with stdenv.lib.
Do I resubmit another pull request with that corrected or something ?

@Chaddai
Copy link
Contributor Author

Chaddai commented Oct 30, 2013

Or ... I'll just add a commit to correct that ? Sorry but I'm not very familiar with Git and Github yet

@domenkozar
Copy link
Member

Just add another commit and push

cillianderoiste added a commit that referenced this pull request Oct 30, 2013
Adding KVIrc : a IRC Client for Qt and KDE. in kde4.kvirc
@cillianderoiste cillianderoiste merged commit ddc809d into NixOS:master Oct 30, 2013
@cillianderoiste
Copy link
Member

Awesome, thanks!

@Janik-Haag Janik-Haag added the 12.first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants