Skip to content

linux-firmware: use commit instead of tag#114588

Closed
raboof wants to merge 1 commit intoNixOS:masterfrom
raboof:linux-firmware-use-commit-instead-of-tag
Closed

linux-firmware: use commit instead of tag#114588
raboof wants to merge 1 commit intoNixOS:masterfrom
raboof:linux-firmware-use-commit-instead-of-tag

Conversation

@raboof
Copy link
Member

@raboof raboof commented Feb 27, 2021

Motivation for this change

Since the repo appears to be somewhat corrupted and switching to the tag
from nix-build does not currently work consistently.

#114439

Things done

Tested with nix-build and the --option substitute false option to
verify nix isn't using the sha256. Indeed this failed without the change
and succeeded after the change.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Since the repo appears to be somewhat corrupted and switching to the tag
from nix-build does not currently work consistently.

NixOS#114439
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/what-are-your-goals-for-21-05/11559/4

@raboof
Copy link
Member Author

raboof commented Feb 27, 2021

Result of nixpkgs-review pr 114588 run on x86_64-linux 1

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Feb 27, 2021
@primeos
Copy link
Member

primeos commented Mar 14, 2021

Let's close this in favor of #116306 :)

@primeos primeos closed this Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants