linux-firmware: use commit instead of tag#114588
Closed
raboof wants to merge 1 commit intoNixOS:masterfrom
Closed
Conversation
Since the repo appears to be somewhat corrupted and switching to the tag from nix-build does not currently work consistently. NixOS#114439
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/what-are-your-goals-for-21-05/11559/4 |
Member
Author
|
Result of |
Member
|
Let's close this in favor of #116306 :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Since the repo appears to be somewhat corrupted and switching to the tag
from nix-build does not currently work consistently.
#114439
Things done
Tested with
nix-buildand the--option substitute falseoption toverify nix isn't using the sha256. Indeed this failed without the change
and succeeded after the change.
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)