Skip to content

Comments

gnome3.gdm: use white nixos logo#114387

Merged
worldofpeace merged 1 commit intoNixOS:masterfrom
worldofpeace:gdm-new-logo
Feb 25, 2021
Merged

gnome3.gdm: use white nixos logo#114387
worldofpeace merged 1 commit intoNixOS:masterfrom
worldofpeace:gdm-new-logo

Conversation

@worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Feb 25, 2021

Motivation for this change

Part of #114000

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace worldofpeace mentioned this pull request Feb 25, 2021
Merged
16 tasks
@ofborg ofborg bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Feb 25, 2021
@ofborg ofborg bot requested review from dasj19, hedning and jtojnar February 25, 2021 18:46
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Feb 25, 2021
@r-rmcgibbo
Copy link

r-rmcgibbo commented Feb 25, 2021 •
edited
Loading

Result of nixpkgs-review pr 114387 at 3e0296b run on aarch64-linux 1

1 package marked as broken and skipped:
  • xmonad_log_applet
15 packages built:
2 suggestions:
  • warning: unused-argument

    Unused argument: librsvg.
    Near pkgs/desktops/gnome-3/core/gdm/default.nix:27:3:

       |
27 | , librsvg
   |   ^
  • warning: unused-argument

    Unused argument: libxml2.
    Near pkgs/desktops/gnome-3/core/gdm/default.nix:12:3:

       |
12 | , libxml2
   |   ^

Result of nixpkgs-review pr 114387 at 3e0296b run on x86_64-linux 1

1 package marked as broken and skipped:
  • xmonad_log_applet
16 packages built:
2 suggestions:
  • warning: unused-argument

    Unused argument: librsvg.
    Near pkgs/desktops/gnome-3/core/gdm/default.nix:27:3:

       |
27 | , librsvg
   |   ^
  • warning: unused-argument

    Unused argument: libxml2.
    Near pkgs/desktops/gnome-3/core/gdm/default.nix:12:3:

       |
12 | , libxml2
   |   ^

jtojnar
jtojnar approved these changes Feb 25, 2021
View reviewed changes
Copy link
Member

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright:

Screenshot from 2021-02-25 21-07-10

@worldofpeace worldofpeace merged commit 9f4049e into NixOS:master Feb 25, 2021
@worldofpeace worldofpeace deleted the gdm-new-logo branch February 25, 2021 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jtojnar jtojnar jtojnar approved these changes

@hedning hedning Awaiting requested review from hedning

@dasj19 dasj19 Awaiting requested review from dasj19

Assignees

No one assigned

Labels

6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@worldofpeace @r-rmcgibbo @jtojnar