Fvwm: add gestures and create libstroke package#11432
Merged
2 commits merged intoNixOS:masterfrom Dec 9, 2015
Merged
Conversation
|
I think since libstoreke is small, just add it to fvwm is enough. |
Contributor
Author
|
@iyzsong - I don't quite follow. Are you suggesting that gestures should be enabled by default? I'd be fine with that; I was just trying to make this as non-intrusive as possible (and figure out if I'm doing flags correctly). Otherwise, I think it's ready to merge. |
ghost
pushed a commit
that referenced
this pull request
Dec 9, 2015
Fvwm: add gestures and create libstroke package
ghost
merged commit
|
Yeah, I think the gestures option is not worth adding. |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds libstroke so that fvwm can be compiled with gesture support, as well as a flag to enable it in fvwm.
This is my first non-trivial contribution, so is largely pattern-matched from existing packages. Feedback is welcome.