xserver: dwm as a window manager

[zenhack]

No description provided.

[mention-bot]

By analyzing the blame information on this pull request, we identified @nbp, @AndersonTorres and @edolstra to be potential reviewers

[jagajaga]

Please use mkEnableOption.

[zenhack]

Quoting Arseniy Seroka (2015-12-03 08:27:59)

• services.xserver.windowManager.dwm.enable = mkOption {

Please use mkEnableOption.

Can do. I based this off of another one of the files in that directory,
which still uses mkOption. I gather this is a deprecated way of doing
things that hasn't be cleaned up everywhere? Would a (separate) patch
that updates the rest be welcome?

[jagajaga]

Yes! That's going to be great work.
On 4 Dec 2015 01:47, "Ian Denhardt" notifications@github.com wrote:

In nixos/modules/services/x11/window-managers/dwm.nix
#11415 (comment):

+with lib;
+
+let
+

• cfg = config.services.xserver.windowManager.dwm;

+in
+
+{
+

• interface

• options = {

• services.xserver.windowManager.dwm.enable = mkOption {

Quoting Arseniy Seroka (2015-12-03 08:27:59)

• services.xserver.windowManager.dwm.enable = mkOption { Please use
  mkEnableOption.
  Can do. I based this off of another one of the files in that directory,
  which still uses mkOption. I gather this is a deprecated way of doing
  things that hasn't be cleaned up everywhere? Would a (separate) patch that
  updates the rest be welcome?

—
Reply to this email directly or view it on GitHub
https://github.com/NixOS/nixpkgs/pull/11415/files#r46624887.

[zenhack]

I've made the change you requested.

[AndersonTorres]

Hum, so far so good. What about a fat commit changing all relevant files? I will do it now.

[zenhack]

The travis failure seems to be unrelated to my change; error messages are talking about virt-manager and glance.

the mkEnableOption looks to be all over the source tree, not just in window-managers.