Skip to content

stdenv/check-meta: change to allowlist and blocklist#114127

Merged
worldofpeace merged 2 commits intoNixOS:masterfrom
worldofpeace:blocklist-allowlist
Feb 23, 2021
Merged

stdenv/check-meta: change to allowlist and blocklist#114127
worldofpeace merged 2 commits intoNixOS:masterfrom
worldofpeace:blocklist-allowlist

Conversation

@worldofpeace
Copy link
Contributor

Motivation for this change

It felt significant to make this rename...
I haven't thought of the way to make it throw with instructions to change to the new attr, and I still need to make documentation for it. For now it will be a draft until I get back to it. But if anyone wants to finish that go ahead.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@grahamc grahamc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. One way we could merge it right away is by falling back to the old names if the new names are not present. It would not throw / warn, but it would get us a step further.

@ofborg ofborg bot added 6.topic: stdenv Standard environment 8.has: documentation This PR adds or changes documentation labels Feb 23, 2021
Co-authored-by: Graham Christensen <graham@grahamc.com>
@worldofpeace worldofpeace marked this pull request as ready for review February 23, 2021 14:50
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Feb 23, 2021
@worldofpeace worldofpeace merged commit 4b10920 into NixOS:master Feb 23, 2021
@worldofpeace worldofpeace deleted the blocklist-allowlist branch February 23, 2021 15:25
@worldofpeace
Copy link
Contributor Author

I can make a release note later. Will also do nixos option renames.

@mohe2015
Copy link
Contributor

mohe2015 commented Feb 23, 2021

Too late but why not allowedLicenses and forbiddenLicenses?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: stdenv Standard environment 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants