stdenv/check-meta: change to allowlist and blocklist#114127
Merged
worldofpeace merged 2 commits intoNixOS:masterfrom Feb 23, 2021
Merged
stdenv/check-meta: change to allowlist and blocklist#114127worldofpeace merged 2 commits intoNixOS:masterfrom
worldofpeace merged 2 commits intoNixOS:masterfrom
Conversation
grahamc
approved these changes
Feb 23, 2021
Member
grahamc
left a comment
There was a problem hiding this comment.
This looks good. One way we could merge it right away is by falling back to the old names if the new names are not present. It would not throw / warn, but it would get us a step further.
Co-authored-by: Graham Christensen <graham@grahamc.com>
Contributor
Author
|
I can make a release note later. Will also do nixos option renames. |
Contributor
|
Too late but why not |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
It felt significant to make this rename...
I haven't thought of the way to make it throw with instructions to change to the new attr, and I still need to make documentation for it. For now it will be a draft until I get back to it. But if anyone wants to finish that go ahead.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)