Merged
Conversation
added 4 commits
December 2, 2015 20:36
This option allows user to specify a url prefix for owncloud. By default it is set to "" and the document root will be set to owncloud's dir. If a prefix is set, e.g. urlPrefix = "/owncloud" an alias will be created using that prefix to point to owncloud's dir and owncloud will be available at http://localhost/owncloud
Commit changes default version to 7.0.10, 7.0.5 version is kept for people reluctant to update. Needed info has also been added for versions 8.0, 8.1 and 8.2 only the latest minor version of each major version is included.
When an empty string was given as trusted_domain, the trusted domain was set to be empty string instead of not beeing set.
Owncloud package used can now be set in configuration.nix using package option.
|
By analyzing the blame information on this pull request, we identified @pSub and @philandstuff to be potential reviewers |
Contributor
|
@matejc |
Contributor
Author
|
@aborsu, thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the rebase went a bit wrong I decided to help @aborsu (#10514) with that
by creating a new branch from master and cherry-picking his commits into, that how this pull request started.
@aborsu: do check the commits if I missed something when cherry-picking commits.
@aborsu: I have reviewed your code, looks solid, and specially... it works great, I will merge it as soon as travis-ci goes green and that you recheck the commits.
I have tried with multiple versions of owncloud and this is config for
nixos-container:I think there is no need for #10514 to exist anymore so it should be closed.