virt-manager: support building on darwin

[basvandijk]

Motivation for this change

This enables building and running virt-manager on darwin.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[basvandijk]

@GrahamcOfBorg build virt-manager

[r-rmcgibbo]

Result of nixpkgs-review pr 113306 at b88422c run on x86_64-linux 1

4 packages built:

• gnome3.gnome-boxes
• libvirt-glib
• virt-manager
• virt-viewer

2 suggestions:

• warning: maintainers-missing

  Package does not have a maintainer. Consider adding yourself?

  Near pkgs/development/libraries/libvirt-glib/default.nix:25:3:

     |
  25 |   meta = with lib; {
     |   ^
  

• warning: unused-argument

  Unused argument: glib.
  Near pkgs/applications/virtualization/virt-manager/default.nix:4:30:

    |
  4 | , gsettings-desktop-schemas, glib, libosinfo, gnome3
    |                              ^
  

---

Result of nixpkgs-review pr 113306 at b88422c run on aarch64-linux 1

4 packages built:

• gnome3.gnome-boxes
• libvirt-glib
• virt-manager
• virt-viewer

2 suggestions:

• warning: maintainers-missing

  Package does not have a maintainer. Consider adding yourself?

  Near pkgs/development/libraries/libvirt-glib/default.nix:25:3:

     |
  25 |   meta = with lib; {
     |   ^
  

• warning: unused-argument

  Unused argument: glib.
  Near pkgs/applications/virtualization/virt-manager/default.nix:4:30:

    |
  4 | , gsettings-desktop-schemas, glib, libosinfo, gnome3
    |                              ^
  

[SuperSandro2000]

Suggested change

	, gsettings-desktop-schemas, glib, libosinfo, gnome3
	, gsettings-desktop-schemas, glib, libosinfo, gnome3

Suggested change

	, gsettings-desktop-schemas, glib, libosinfo, gnome3
	, gsettings-desktop-schemas, libosinfo, gnome3

[SuperSandro2000]

Suggested change

	, spiceSupport ? !stdenv.isDarwin, spice-gtk ? null
	, spiceSupport ? !stdenv.isDarwin, spice-gtk

[SuperSandro2000]

Suggested change

	]
	++ optional spiceSupport spice-gtk
	++ optionals (!stdenv.isDarwin) [ gtk-vnc vte ];
	] ++ optional spiceSupport spice-gtk
	++ optionals (!stdenv.isDarwin) [ gtk-vnc vte ];

[SuperSandro2000]

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 113306 run on x86_64-linux 1

4 packages built:

• gnome3.gnome-boxes
• libvirt-glib
• virt-manager
• virt-viewer

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

gnome3.gnome-boxes:

Details

gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.

Near pkgs/desktops/gnome-3/apps/gnome-boxes/default.nix:141:5:

    |
141 |     license = licenses.gpl3;
    |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

libvirt-glib:

Details

Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/libraries/libvirt-glib/default.nix:25:3:

   |
25 |   meta = with lib; {
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md
gobject-introspection is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

Near pkgs/development/libraries/libvirt-glib/default.nix:19:3:

   |
19 |   buildInputs = [ libvirt libxml2 gobject-introspection ]
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md

virt-manager:

Details

Unused argument: glib.
Near pkgs/applications/virtualization/virt-manager/default.nix:4:30:

  |
4 | , gsettings-desktop-schemas, glib, libosinfo, gnome3
  |                              ^

virt-viewer:

Details

gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

Near pkgs/applications/virtualization/virt-viewer/default.nix:39:5:

   |
39 |     license = licenses.gpl2;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

[siraben]

Please resolve the merge conflict.

[stale]

I marked this as stale due to inactivity. → More info

[mikroskeem]

Any updates on this?

[AndersonTorres]

Closing because #152350 will supercede this.