nixos/postgresql: enable sandbox mode#113100
Conversation
a7c46d4 to
70b1d13
Compare
aszlig
left a comment
There was a problem hiding this comment.
Minimal testing.
I think we should especially test this with a few extensions (eg. postgis) and involve a few more folks using PostgreSQL before merging this, because reverting this on a per-config basis will be a bit more involved with all the options set.
There was a problem hiding this comment.
Did you try the systemd.services.*.confinement options instead? I'm asking because one of the main targets of that module was PostgreSQL and it's also more strict that ProtectSystem because it only contains runtime closure necessary for running PostgreSQL.
There was a problem hiding this comment.
Have not tried. Don't know how to use systemd.services.*.confinement.
There was a problem hiding this comment.
If that's the case, we should fix the test and not the other way around. One of the reasons why we've switched to /run/postgresql is because it makes sandboxing more difficult as outlined in #57677.
There was a problem hiding this comment.
Now there is no idea how to fix the test.
70b1d13 to
60f74de
Compare
|
I marked this as stale due to inactivity. → More info |
|
Closing, because #344925 has been merged. |
Motivation for this change
Running postgresql service in sandbox mode.
Minimal testing.
cc @aanderse @flokli
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)