Skip to content

python3Packages.starlette: 0.13.8 -> 0.14.2#112142

Closed
dotlambda wants to merge 1 commit intoNixOS:masterfrom
dotlambda:starlette-0.14.2
Closed

python3Packages.starlette: 0.13.8 -> 0.14.2#112142
dotlambda wants to merge 1 commit intoNixOS:masterfrom
dotlambda:starlette-0.14.2

Conversation

@dotlambda
Copy link
Member

Motivation for this change

doesn't build on master

Maybe we should not update but just fix the tests because this breaks fastapi: fastapi/fastapi#2335.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Feb 6, 2021
@ofborg ofborg bot requested a review from wd15 February 6, 2021 13:27
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 6, 2021
@mweinelt
Copy link
Member

mweinelt commented Feb 6, 2021

#111079

@dotlambda dotlambda closed this Feb 6, 2021
@dotlambda dotlambda deleted the starlette-0.14.2 branch February 6, 2021 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants