Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.pixelmatch: init at 0.2.2 #111958

Merged
merged 1 commit into from Feb 7, 2021
Merged

python3Packages.pixelmatch: init at 0.2.2 #111958

merged 1 commit into from Feb 7, 2021

Conversation

ghost
Copy link

@ghost ghost commented Feb 4, 2021 •
edited by ghost
Loading

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghost ghost requested review from FRidh and jonringer as code owners February 4, 2021 20:55
@ghost ghost changed the title Feature/pixelmatch python3Packages.pixelmatch: init at 0.2.1 Feb 4, 2021
@ofborg ofborg bot added 6.topic: python 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Feb 4, 2021
@ghost ghost requested a review from fabaff February 6, 2021 18:16
@ghost ghost changed the title python3Packages.pixelmatch: init at 0.2.1 python3Packages.pixelmatch: init at 0.2.2 Feb 6, 2021
@mweinelt mweinelt merged commit b22a1c4 into NixOS:master Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@fabaff fabaff Awaiting requested review from fabaff

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fabaff @mweinelt