Skip to content

Comments

llvmPackages_11.compiler-rt: fix build on darwin#111701

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
r-burns:compiler-rt
Mar 4, 2021
Merged

llvmPackages_11.compiler-rt: fix build on darwin#111701
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
r-burns:compiler-rt

Conversation

@r-burns
Copy link
Contributor

@r-burns r-burns commented Feb 3, 2021

Needed to prevent faulty i686 codegen on x86_64. We're doing this
already for the older llvm packages, so not sure why 11 never had this.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Needed to prevent faulty i686 codegen on x86_64. We're doing this
already for the older llvm packages, so not sure why 11 never had this.
@r-burns r-burns requested a review from matthewbauer as a code owner February 3, 2021 04:49
@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Feb 3, 2021
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111701 run on x86_64-darwin 1

2 packages marked as broken and skipped:
  • puppeteer-cli
  • zig
2 packages built:
  • clang-analyzer
  • clang_11

@thefloweringash thefloweringash mentioned this pull request Feb 8, 2021
14 tasks
Copy link
Contributor

@Luflosi Luflosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@SuperSandro2000 SuperSandro2000 merged commit dc00d91 into NixOS:master Mar 4, 2021
@r-burns r-burns deleted the compiler-rt branch March 4, 2021 02:59
@rrbutani rrbutani added the 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: darwin Running or building packages on Darwin 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants