Skip to content

haskellPackages.hum: broken -> unbroken#111538

Merged
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
iyefrat:haskell-updates
Feb 3, 2021
Merged

haskellPackages.hum: broken -> unbroken#111538
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
iyefrat:haskell-updates

Conversation

@iyefrat
Copy link
Contributor

@iyefrat iyefrat commented Feb 1, 2021

Motivation for this change

hum's build succeeds now.

Things done

Removed hum from the broken haskell pakcages list.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@iyefrat iyefrat requested a review from cdepillabout as a code owner February 1, 2021 09:38
@ofborg ofborg bot added 6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Feb 1, 2021
@cdepillabout
Copy link
Member

Trying to build hum on this commit appears to not work because of a dependency:

$ nix-build -A haskellPackages.hum
these derivations will be built:
  /nix/store/zfjx2nr4m8fhzcrsxzflpp6bjl8lpqdv-hum-0.2.0.0.drv
building '/nix/store/zfjx2nr4m8fhzcrsxzflpp6bjl8lpqdv-hum-0.2.0.0.drv'...
setupCompilerEnvironmentPhase
Build with /nix/store/hqy95jvfksyk3sr77ky6m06ddy99iszz-ghc-8.10.3.
unpacking sources
unpacking source archive /nix/store/wmsy9j77b3yisngkq5df5f69x68amm15-hum-0.2.0.0.tar.gz
source root is hum-0.2.0.0
setting SOURCE_DATE_EPOCH to timestamp 1000000000 of file hum-0.2.0.0/test/MyLibTest.hs
patching sources
Replace Cabal file with edited version from mirror://hackage/hum-0.2.0.0/revision/1.cabal.
compileBuildDriverPhase
setupCompileFlags: -package-db=/build/setup-package.conf.d -j8 +RTS -A64M -RTS -threaded -rtsopts
[1 of 1] Compiling Main             ( Setup.hs, /build/Main.o )
Linking Setup ...
configuring
configureFlags: --verbose --prefix=/nix/store/40axafsl12wxf5730x6qs1p3kx485y2m-hum-0.2.0.0 --libdir=$prefix/lib/$compiler --libsubdir=$abi/$libname --docdir=/nix/store/06kx1ldc8giszz5qq13pw8zx1jdj4p6q-hum-0.2.0.0-doc/share/doc/hum-0.2.0.0 --with-gcc=gcc --package-db=/build/package.conf.d --ghc-options=-j8 +RTS -A64M -RTS --disable-split-objs --enable-library-profiling --profiling-detail=exported-functions --disable-profiling --enable-shared --disable-coverage --enable-static --disable-executable-dynamic --enable-tests --disable-benchmarks --enable-library-vanilla --disable-library-for-ghci --ghc-option=-split-sections --extra-lib-dirs=/nix/store/bhgwgvcis0cnx32i2fgxx1nxxbxwsckw-ncurses-6.2/lib --extra-lib-dirs=/nix/store/z1kwafc0yf8jzhmm8f0j72nc196jl1sq-libffi-3.3/lib --extra-lib-dirs=/nix/store/fpp0yqcr5il5jaax434kcj5y3qfgwg1l-gmp-6.2.1/lib
Using Parsec parser
Configuring hum-0.2.0.0...
CallStack (from HasCallStack):
  $, called at libraries/Cabal/Cabal/Distribution/Simple/Configure.hs:1024:20 in Cabal-3.2.1.0:Distribution.Simple.Configure
  configureFinalizedPackage, called at libraries/Cabal/Cabal/Distribution/Simple/Configure.hs:477:12 in Cabal-3.2.1.0:Distribution.Simple.Configure
  configure, called at libraries/Cabal/Cabal/Distribution/Simple.hs:625:20 in Cabal-3.2.1.0:Distribution.Simple
  confHook, called at libraries/Cabal/Cabal/Distribution/Simple/UserHooks.hs:65:5 in Cabal-3.2.1.0:Distribution.Simple.UserHooks
  configureAction, called at libraries/Cabal/Cabal/Distribution/Simple.hs:180:19 in Cabal-3.2.1.0:Distribution.Simple
  defaultMainHelper, called at libraries/Cabal/Cabal/Distribution/Simple.hs:116:27 in Cabal-3.2.1.0:Distribution.Simple
  defaultMain, called at Setup.hs:2:8 in main:Main
Setup: Encountered missing or private dependencies:
brick ==0.58.*

builder for '/nix/store/zfjx2nr4m8fhzcrsxzflpp6bjl8lpqdv-hum-0.2.0.0.drv' failed with exit code 1
error: build of '/nix/store/zfjx2nr4m8fhzcrsxzflpp6bjl8lpqdv-hum-0.2.0.0.drv' failed

@iyefrat
Copy link
Contributor Author

iyefrat commented Feb 1, 2021

@cdepillabout I uploaded a new revision to hackage that fixes this, it should work now. I initially checked it on git head that had looser version restrictions, hence the mixup. Although if my understanding of how all this works is correct, that might mean that it will only work here after the next hackage merge commit.

@cdepillabout
Copy link
Member

hum now builds on haskell-updates. Thanks!

You can track #111678 to see when this will be merged into master.

@cdepillabout cdepillabout merged commit 3ce4ff7 into NixOS:haskell-updates Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants