Skip to content

python3Packages.starlette: fix build #111079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mweinelt merged 1 commit into from
Feb 11, 2021
Merged

python3Packages.starlette: fix build #111079

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions pkgs/development/python-modules/starlette/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
, databases
, pytestCheckHook
, pytest-asyncio
, pytestcov
, typing-extensions
, ApplicationServices
}:
Expand Down Expand Up @@ -46,12 +45,14 @@ buildPythonPackage rec {
checkInputs = [
aiosqlite
databases
pytest-asyncio
pytestCheckHook
typing-extensions
];

pytestFlagsArray = [ "--ignore=tests/test_graphql.py" ];

disabledTestFiles = [ "tests/test_graphql.py" ];
# https://github.com/encode/starlette/issues/1131

@mweinelt mweinelt Feb 10, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This issue was closed 10 days ago. Is the test working now? Can we fetch a patch?

@mweinelt mweinelt Feb 11, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the package to 0.14.2 and dropped the disable.

@mweinelt mweinelt Feb 11, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, this breaks fastapi because they still haven't gotten rid of UJSONResponse.

disabledTests = [ "test_debug_html" ];
pythonImportsCheck = [ "starlette" ];

meta = with lib; {
Expand Down