Add a way to pin a NixOS version within the module system.#11106
Merged
nbp merged 1 commit intoNixOS:masterfrom Nov 20, 2015
Merged
Add a way to pin a NixOS version within the module system.#11106nbp merged 1 commit intoNixOS:masterfrom
nbp merged 1 commit intoNixOS:masterfrom
Conversation
Member
Member
Author
|
@copumpkin Yes, this solves #7467. |
Member
|
👍 |
Member
Author
|
The latest patch add documentation for the module and a changelog entry. The only remaining part is to add the test into the test infrastructure. |
Member
Author
Member
|
@nbp Nice approach, looks good to me. |
nixos/modules/misc/nixos.xml
Outdated
Member
Author
There was a problem hiding this comment.
No, this is a mix of 2 idea, I will keep the bottom one for now.
Member
This modification add a way to re-evaluate the module system with a different version of NixOS, or with a different set of arguments.
nbp
added a commit
that referenced
this pull request
Nov 20, 2015
Add a way to pin a NixOS version within the module system.
Member
|
🍻 |
Member
|
🤗
|
Contributor
|
nice, thanks :) |
Member
|
Sounds useful 👍 |
Member
Author
|
These changes got reverted in commit d4636fa |
Member
|
@edolstra while in general the
I don't know if this is the implementation we'll end up using, but do you agree that given the above this is at least something that's nice to have, even given the existence of cc @grahamc given his interest in NixOS/nixops#649 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This modification add a way to re-evaluate the module system with a
different version of NixOS, or with a different set of arguments.
cc @garbas