Skip to content

haskellPackages.glicko: unbreak#110161

Merged
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
Prillan:unbreak-glicko
Jan 22, 2021
Merged

haskellPackages.glicko: unbreak#110161
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
Prillan:unbreak-glicko

Conversation

@Prillan
Copy link
Contributor

@Prillan Prillan commented Jan 20, 2021

I'm the author of the package and fixed the dependencies upstream, now builds correctly and can be unmarked as broken.

Tested with current unstable (4eccd6f).

nix-shell -p 'haskellPackages.ghcWithPackages (pkgs: [pkgs.glicko])' -I nixpkgs=https://github.com/NixOS/nixpkgs/archive/4eccd6f731627ba5ad9915bcf600c9329a34ca78.tar.gz

@Prillan Prillan requested a review from cdepillabout as a code owner January 20, 2021 13:25
@ofborg ofborg bot added 6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jan 20, 2021
@iblech
Copy link
Contributor

iblech commented Jan 20, 2021

Can confirm that glicko builds just fine, thank you for your work :-)

Copy link
Member

@cdepillabout cdepillabout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Prillan Can you rebase this on the haskell-updates branch (and make sure to change the base branch here on GitHub as well)?

After you make this change, I'll merge in this PR.


We generally try to make most Haskell-related changes to the haskell-updates branch. That branch gets merged into master about once a week. Here's the next PR that will get merged into master, in case you want to follow progress: #109474

I'm the author of the package and fixed the dependencies upstream,
now builds correctly and can be unmarked as broken.
@Prillan Prillan changed the base branch from master to haskell-updates January 21, 2021 12:21
@Prillan
Copy link
Contributor Author

Prillan commented Jan 21, 2021

@Prillan Can you rebase this on the haskell-updates branch (and make sure to change the base branch here on GitHub as well)?

After you make this change, I'll merge in this PR.

Done!

We generally try to make most Haskell-related changes to the haskell-updates branch. That branch gets merged into master about once a week. Here's the next PR that will get merged into master, in case you want to follow progress: #109474

Alright, that makes sense, thanks!

@Prillan Prillan requested a review from cdepillabout January 21, 2021 12:23
@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 2501-5000 This PR causes many rebuilds on Darwin and should target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 2501-5000 This PR causes many rebuilds on Darwin and should target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. labels Jan 21, 2021
@cdepillabout
Copy link
Member

@Prillan Thanks for unbreaking this.

@iblech and thanks for reviewing.

@cdepillabout cdepillabout merged this pull request into NixOS:haskell-updates Jan 22, 2021
@Prillan Prillan deleted the unbreak-glicko branch January 22, 2021 19:34
@Janik-Haag Janik-Haag added the 12.first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants