Conversation
2f5c395 to
6584ebc
Compare
6584ebc to
cfdba72
Compare
|
I assume CI is needed because there is no different way to prevent people from pushing to these branches? |
I think admins ignore the branch protection. |
|
NixOS/ofborg#546 does similar to this with Being able to "require" |
I think the major concern there was that if ofborg would be not available the whole nixpkgs development would break. There are probably less concerns with github actions as there is a dedicated team with pager duty. |
Co-authored-by: Cole Helbling <cole.e.helbling@outlook.com>
|
I marked this as stale due to inactivity. → More info |
* ci: add no-channel check * Update .github/workflows/no-channel.yml Co-authored-by: Cole Helbling <cole.e.helbling@outlook.com> Co-authored-by: Cole Helbling <cole.e.helbling@outlook.com> (cherry picked from commit b8297c0)
|
Tested and #130906 works as expected |
Motivation for this change
Somebody merged a change in
nixos-20.09. See #109384Proposal
This is a proposal to prevent such issues in the future.
Here is how the error looks like:
And the branch protection change that would be put in place:
