Skip to content

nixos/tor: fix openFirewall when ORPort isInt#109096

Merged
Mic92 merged 1 commit intoNixOS:masterfrom
ju1m:tor
Jan 15, 2021
Merged

nixos/tor: fix openFirewall when ORPort isInt#109096
Mic92 merged 1 commit intoNixOS:masterfrom
ju1m:tor

Conversation

@ju1m
Copy link
Contributor

@ju1m ju1m commented Jan 12, 2021 •
edited
Loading

Motivation for this change

Fix #97740 (comment)

Things done
  • Handle case when ˋORPortˋ and ˋDirPortˋ are integers and not attrsets.
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Ping @Mic92

@ju1m ju1m mentioned this pull request Jan 12, 2021
Merged
19 tasks
@Mic92 Mic92 requested a review from delroth January 12, 2021 10:03
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jan 12, 2021
@Mic92 Mic92 merged commit 9c4a185 into NixOS:master Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@delroth delroth Awaiting requested review from delroth

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ju1m @Mic92