Skip to content

Comments

[20.09] gist: 5.1.0 -> 6.0.0 #109032

Merged
zimbatm merged 1 commit intoNixOS:release-20.09from
leo60228:20.09-gist-6.0.0
Jan 11, 2021
Merged

[20.09] gist: 5.1.0 -> 6.0.0 #109032
zimbatm merged 1 commit intoNixOS:release-20.09from
leo60228:20.09-gist-6.0.0

Conversation

@leo60228
Copy link
Member

@leo60228 leo60228 commented Jan 11, 2021

(cherry picked from commit c80258a)

Motivation for this change

The login API used in gist before 6.0.0 was removed, meaning that the package is broken for new users.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kalbasit @leo60228
gist: 5.1.0 -> 6.0.0 (NixOS#98053)
81d0b91 
(cherry picked from commit c80258a)

Reason: login API in used in gist before 6.0.0 was removed
@ofborg ofborg bot requested a review from zimbatm January 11, 2021 18:05
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jan 11, 2021
@hugolgst
Copy link
Member

hugolgst commented Jan 11, 2021 •
edited
Loading

Looks good to me.

Result of nixpkgs-review pr 109032 1

1 package built:
  • gist

@zimbatm zimbatm merged commit cbce0a3 into NixOS:release-20.09 Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zimbatm zimbatm Awaiting requested review from zimbatm

1 more reviewer

@hugolgst hugolgst hugolgst approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@leo60228 @hugolgst @zimbatm @kalbasit