Skip to content

perl-packages: stdenv.lib -> lib#108927

Merged
Profpatsch merged 1 commit intoNixOS:masterfrom
Profpatsch:perl-packages-lib-stdenv
Jan 10, 2021
Merged

perl-packages: stdenv.lib -> lib#108927
Profpatsch merged 1 commit intoNixOS:masterfrom
Profpatsch:perl-packages-lib-stdenv

Conversation

@Profpatsch
Copy link
Member

@Profpatsch Profpatsch commented Jan 10, 2021

The library does not depend on stdenv, that stdenv exposes lib is
an artifact of the ancient origins of nixpkgs.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Profpatsch
perl-packages: stdenv.lib -> lib
33aeb4d 
The library does not depend on stdenv, that `stdenv` exposes `lib` is
an artifact of the ancient origins of nixpkgs.
@Profpatsch Profpatsch requested a review from stigtsp as a code owner January 10, 2021 10:09
@Profpatsch
Copy link
Member Author

Profpatsch commented Jan 10, 2021

@GrahamcOfBorg build perlPackages

siraben
siraben approved these changes Jan 10, 2021
View reviewed changes
Copy link
Member

@siraben siraben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No more occurrences of stdenv.lib.

alyssais
alyssais approved these changes Jan 10, 2021
View reviewed changes
Copy link
Member

@alyssais alyssais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming OfBorg finds it to be rebuild-0.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jan 10, 2021
@Profpatsch
Copy link
Member Author

Profpatsch commented Jan 10, 2021

Everything green, 0 rebuilds, except the darwin build, which is afaik still broken in ofborg.

@Profpatsch Profpatsch merged commit 276f91e into NixOS:master Jan 10, 2021
@stigtsp
Copy link
Member

stigtsp commented Jan 10, 2021 •
edited
Loading

Hi, some notes:

  • maintainers/scripts/nix-generate-from-cpan.pl needs to be updated
  • A bulk update of perlPackages is in staging-next Staging next #108423

@stigtsp stigtsp mentioned this pull request Jan 10, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alyssais alyssais alyssais approved these changes

@siraben siraben siraben approved these changes

@stigtsp stigtsp Awaiting requested review from stigtsp

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Profpatsch @stigtsp @alyssais @siraben