Skip to content

haskellPackages.threadscope: Remove jailbreak after package update#108922

Merged
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
markus1189:threadscope
Jan 10, 2021
Merged

haskellPackages.threadscope: Remove jailbreak after package update#108922
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
markus1189:threadscope

Conversation

@markus1189
Copy link
Contributor

@markus1189 markus1189 commented Jan 10, 2021

Thanks to a new
release (haskell/ThreadScope#116) threadscope
can now be built without jailbreak. 🎉

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@markus1189
haskellPackages.threadscope: Remove jailbreak after package update
59d349a 
Thanks to a new
release (haskell/ThreadScope#116) threadscope
can now be built without jailbreak. 🎉
@ofborg ofborg bot added 6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jan 10, 2021
@cdepillabout
Copy link
Member

cdepillabout commented Jan 10, 2021

Thanks for keeping an eye on this!

@cdepillabout cdepillabout merged commit 38201ec into NixOS:haskell-updates Jan 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

Assignees

No one assigned

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@markus1189 @cdepillabout