Skip to content

haskellPackages.nothunks: jailbreak to fix tests#108788

Merged
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
expipiplus1:joe-nothunks
Jan 9, 2021
Merged

haskellPackages.nothunks: jailbreak to fix tests#108788
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
expipiplus1:joe-nothunks

Conversation

@expipiplus1
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@cdepillabout cdepillabout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks like this compiles!

@cdepillabout cdepillabout merged commit 6e80b3b into NixOS:haskell-updates Jan 9, 2021
@expipiplus1 expipiplus1 deleted the joe-nothunks branch January 9, 2021 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants