co-log, chronos: unmarkBroken by disabling tests for chronos#108780
co-log, chronos: unmarkBroken by disabling tests for chronos#108780cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
Conversation
There was a problem hiding this comment.
Instead of marking these unbroken here, can you just remove them from the broken-packages list in configuration-hackage2nix.yaml?
Here is a PR doing something similar: https://github.com/NixOS/nixpkgs/pull/108788/files#diff-3139f03f40f0c7740a4003f88522ac0af603af77f746f3e6bb8e26cccc1eaf88L8334
This this, you can remove the co-log = line, and just keep the chronos = dontCheck super.chronos; line.
Also, thanks for linking to the upstream issue for chronos!
co-log fails to compile due to its dependency on chronos, which fails to compile because the doctests fail with newer GHC versions. So we just disable the doctests and thus unbreak both. byteverse/chronos#62
|
Thanks @cdepillabout it's a bit embarrassing that I didn't check this myself 🙈 I just looked at the rest of the file and saw lots of The diff is now down to removing |
|
Looks good, thanks for this change! |
Motivation for this change
The only reason
co-logis broken because one of its dependencieschronosfails the doctests on GHC 8.10. I created an issue in thechronosrepo but I think we can unbreak both packages until that is resolvedWill run nix review once PR is upStrangely
nix reviewsays nothing to be builtThings done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)