Skip to content

profiteur: jailbreak and un-break#108452

Merged
cdepillabout merged 2 commits intoNixOS:haskell-updatesfrom
cleverca22:jailbreak-profiteur
Jan 8, 2021
Merged

profiteur: jailbreak and un-break#108452
cdepillabout merged 2 commits intoNixOS:haskell-updatesfrom
cleverca22:jailbreak-profiteur

Conversation

@cleverca22
Copy link
Contributor

@cleverca22 cleverca22 commented Jan 5, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cleverca22 cleverca22 mentioned this pull request Jan 5, 2021
Merged
@ofborg ofborg bot added 6.topic: haskell General-purpose, statically typed, purely functional programming language 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jan 5, 2021
cdepillabout
cdepillabout requested changes Jan 5, 2021
View reviewed changes
Copy link
Member

@cdepillabout cdepillabout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase this on the haskell-updates branch (instead of master)?

Also, could you remove profiteur from the list of broken-packages in configuration-hackage2nix.yaml?

@cleverca22 cleverca22 force-pushed the jailbreak-profiteur branch from 9ab361d to ab1a92c Compare January 5, 2021 07:35
@cleverca22 cleverca22 changed the base branch from master to haskell-updates January 5, 2021 07:36
@cleverca22
Copy link
Contributor Author

cleverca22 commented Jan 5, 2021

@cdepillabout done!

@jbgi jbgi requested a review from cdepillabout January 5, 2021 08:50
sternenseemann
sternenseemann requested changes Jan 5, 2021
View reviewed changes
@sternenseemann
Copy link
Member

sternenseemann commented Jan 5, 2021

Builds and seems to run fine on x86_64-linux.

@cleverca22 cleverca22 force-pushed the jailbreak-profiteur branch from ab1a92c to c65eb1d Compare January 5, 2021 23:05
@cleverca22 cleverca22 force-pushed the jailbreak-profiteur branch from c65eb1d to 662eba1 Compare January 8, 2021 11:43
cdepillabout
cdepillabout reviewed Jan 8, 2021
View reviewed changes
@cdepillabout
Copy link
Member

cdepillabout commented Jan 8, 2021

@cleverca22 Thanks for working with us on this!

@cdepillabout cdepillabout merged commit 08fc5ef into NixOS:haskell-updates Jan 8, 2021
@cleverca22 cleverca22 deleted the jailbreak-profiteur branch January 8, 2021 13:11
@cleverca22
Copy link
Contributor Author

cleverca22 commented Jan 8, 2021

yep!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cdepillabout cdepillabout cdepillabout requested changes

@sternenseemann sternenseemann sternenseemann approved these changes

Assignees

No one assigned

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cleverca22 @sternenseemann @cdepillabout