Skip to content

kwin: allow using wrapper for qpa#107476

Merged
ttuegel merged 1 commit intoNixOS:masterfrom
CertainLach:kwin-wayland-wrapper
Mar 24, 2021
Merged

kwin: allow using wrapper for qpa#107476
ttuegel merged 1 commit intoNixOS:masterfrom
CertainLach:kwin-wayland-wrapper

Conversation

@CertainLach
Copy link
Member

@CertainLach CertainLach commented Dec 23, 2020

Motivation for this change

See #43757 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@CertainLach
kwin: allow using wrapper for qpa
d7f5ac9 
Signed-off-by: Yaroslav  Bolyukin <iam@lach.pw>
@CertainLach CertainLach requested a review from ttuegel as a code owner December 23, 2020 15:43
@CertainLach CertainLach mentioned this pull request Dec 23, 2020
Merged
10 tasks
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: qt/kde Object-oriented framework for GUI creation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Dec 23, 2020
@CertainLach CertainLach mentioned this pull request Dec 25, 2020
Closed
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Mar 21, 2021

@ttuegel Can you take a look at this?

@ttuegel ttuegel merged commit bd2cf10 into NixOS:master Mar 24, 2021
@ttuegel
Copy link
Member

ttuegel commented Mar 24, 2021

Thanks! 👍

@CertainLach CertainLach deleted the kwin-wayland-wrapper branch February 6, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ttuegel ttuegel ttuegel approved these changes

@ajs124 ajs124 ajs124 approved these changes

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: qt/kde Object-oriented framework for GUI creation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@CertainLach @SuperSandro2000 @ttuegel @ajs124