kinit: increase environment limit#107472
Merged
ttuegel merged 1 commit intoNixOS:masterfrom Jan 2, 2021
Merged
Conversation
Limit is already increased for standard xorg plasma distribution to start, but with wayland, even more libraries being added Increasing this limit to 1 << 20 (1M) seems to be enough (For me length is 80K), and not so much for regular desktops Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
10 tasks
Contributor
|
🤔 I'm wondering why there need to be a troublesome but increase-able limit. Can we simply throw away the check? |
Member
Author
|
@oxalica this check can prevent broken input from being passed to program, so it shouldn't be removed, i think. |
ttuegel
approved these changes
Jan 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Limit is already increased for standard xorg plasma distribution to
start, but with wayland, even more libraries being added
Increasing this limit to 1 << 20 (1M) seems to be enough (For me
length is 80K), and not so much for regular desktops
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)