Skip to content

kinit: increase environment limit#107472

Merged
ttuegel merged 1 commit intoNixOS:masterfrom
CertainLach:increase-kdeinit-environ-limit
Jan 2, 2021
Merged

kinit: increase environment limit#107472
ttuegel merged 1 commit intoNixOS:masterfrom
CertainLach:increase-kdeinit-environ-limit

Conversation

@CertainLach
Copy link
Member

Motivation for this change

Limit is already increased for standard xorg plasma distribution to
start, but with wayland, even more libraries being added

Increasing this limit to 1 << 20 (1M) seems to be enough (For me
length is 80K), and not so much for regular desktops

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Limit is already increased for standard xorg plasma distribution to
start, but with wayland, even more libraries being added

Increasing this limit to 1 << 20 (1M) seems to be enough (For me
length is 80K), and not so much for regular desktops

Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
@CertainLach CertainLach requested a review from ttuegel as a code owner December 23, 2020 14:50
@ofborg ofborg bot added 6.topic: qt/kde Object-oriented framework for GUI creation 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Dec 23, 2020
@oxalica
Copy link
Contributor

oxalica commented Dec 24, 2020

🤔 I'm wondering why there need to be a troublesome but increase-able limit. Can we simply throw away the check?

@CertainLach
Copy link
Member Author

@oxalica this check can prevent broken input from being passed to program, so it shouldn't be removed, i think.
Increasing it to 1M should be enough for a long time

@ttuegel ttuegel merged commit ff47554 into NixOS:master Jan 2, 2021
@CertainLach CertainLach deleted the increase-kdeinit-environ-limit branch January 2, 2021 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: qt/kde Object-oriented framework for GUI creation 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants