pythonPackages.cliff: unbreak build#106866
Closed
IvarWithoutBones wants to merge 1 commit intoNixOS:masterfrom
Closed
pythonPackages.cliff: unbreak build#106866IvarWithoutBones wants to merge 1 commit intoNixOS:masterfrom
IvarWithoutBones wants to merge 1 commit intoNixOS:masterfrom
Conversation
10 tasks
Member
|
I prefer #108977 over this one because it fixes the tests instead of disabling them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Noticed this was failing on Hydra, and decided to fix this.
After the issue seen there is fixed, tests still won't work. Some of the hardcoded paths are not even available anymore, others fail not being able to find the
whichbinary, in thecmd2package.This should be backported.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)