Skip to content

pythonPackages.cliff: unbreak build#106866

Closed
IvarWithoutBones wants to merge 1 commit intoNixOS:masterfrom
IvarWithoutBones:fix-cliff
Closed

pythonPackages.cliff: unbreak build#106866
IvarWithoutBones wants to merge 1 commit intoNixOS:masterfrom
IvarWithoutBones:fix-cliff

Conversation

@IvarWithoutBones
Copy link
Member

Motivation for this change

Noticed this was failing on Hydra, and decided to fix this.
After the issue seen there is fixed, tests still won't work. Some of the hardcoded paths are not even available anymore, others fail not being able to find the which binary, in the cmd2 package.

This should be backported.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Dec 14, 2020
@ofborg ofborg bot requested a review from costrouc December 14, 2020 02:44
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 14, 2020
@lukegb lukegb mentioned this pull request Jan 11, 2021
10 tasks
@SuperSandro2000
Copy link
Member

I prefer #108977 over this one because it fixes the tests instead of disabling them.

@IvarWithoutBones IvarWithoutBones deleted the fix-cliff branch April 4, 2021 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants