Skip to content

scribusUnstable: build with libsForQt5#106781

Merged
erictapen merged 1 commit intoNixOS:masterfrom
erictapen:scribusUnstable-qt515
Dec 15, 2020
Merged

scribusUnstable: build with libsForQt5#106781
erictapen merged 1 commit intoNixOS:masterfrom
erictapen:scribusUnstable-qt515

Conversation

@erictapen
Copy link
Member

See #104474

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Dec 12, 2020
@Kiwi Kiwi self-requested a review December 14, 2020 05:26
Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Diff LGTM
  • Commits LGTM
  • Builds via nix-review on x86-64-linux:
https://github.com/NixOS/nixpkgs/pull/106781
1 package built:
scribusUnstable

Didn't really test beyond this b/c I'm on a headless machine, hence lack of approve/request.

@Kiwi
Copy link
Member

Kiwi commented Dec 15, 2020

I built it on aarch64-linux (not yet tested, I can get on a pi later but haven't yet) and x86_64-linux (launched, LGTM)

unrelated; I attempted x86_64-darwin for kicks since it is currently unsupported and fails but I think it's possible to so I'll try and get working eventually now that I have a darwin builder and am trying to get everything I can supported >.>

@erictapen
Copy link
Member Author

@Kiwi nice, good luck with supporting darwin!

I'll merge this then.

@erictapen erictapen merged commit 3d3c070 into NixOS:master Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants