scribusUnstable: build with libsForQt5#106781
Merged
erictapen merged 1 commit intoNixOS:masterfrom Dec 15, 2020
Merged
Conversation
Contributor
drewrisinger
left a comment
There was a problem hiding this comment.
- Diff LGTM
- Commits LGTM
- Builds via
nix-reviewon x86-64-linux:
https://github.com/NixOS/nixpkgs/pull/106781
1 package built:
scribusUnstable
Didn't really test beyond this b/c I'm on a headless machine, hence lack of approve/request.
Member
|
I built it on aarch64-linux (not yet tested, I can get on a pi later but haven't yet) and x86_64-linux (launched, LGTM) unrelated; I attempted x86_64-darwin for kicks since it is currently unsupported and fails but I think it's possible to so I'll try and get working eventually now that I have a darwin builder and am trying to get everything I can supported >.> |
Member
Author
|
@Kiwi nice, good luck with supporting darwin! I'll merge this then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #104474
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)