Skip to content

Migrate qt515#106742

Merged
doronbehar merged 7 commits intoNixOS:masterfrom
freezeboy:migrate-qt515
Jan 5, 2021
Merged

Migrate qt515#106742
doronbehar merged 7 commits intoNixOS:masterfrom
freezeboy:migrate-qt515

Conversation

@freezeboy
Copy link
Contributor

Motivation for this change

Migrate the packages without a maintainer from PR: #104474

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Dec 12, 2020
@ofborg ofborg bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. and removed 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Dec 15, 2020
Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM!

@doronbehar
Copy link
Contributor

DAMN. Merge conflicts, from right now.

@freezeboy
Copy link
Contributor Author

I resolved the conflict

@doronbehar
Copy link
Contributor

Result of nixpkgs-review pr 106742 run on x86_64-linux 1

9 packages built:
  • bibletime
  • dfilemanager
  • herqq
  • merkaartor
  • mindforger
  • seafile-client
  • seafile-shared
  • solarus
  • solarus-quest-editor

@doronbehar
Copy link
Contributor

doronbehar commented Jan 5, 2021

No unfunctional executables besides:

(ins)[nix-shell:~/.cache/nixpkgs-review/pr-106742-1]$ ./results/seafile-shared/bin/seaf-cli --help
Traceback (most recent call last):
  File "/nix/store/bbp37c848krz0lnkarypkhrsnvjr5bkz-seafile-shared-8.0.1/bin/.seaf-cli-wrapped", line 99, in <module>
    import seafile
  File "/nix/store/bbp37c848krz0lnkarypkhrsnvjr5bkz-seafile-shared-8.0.1/lib/python3.8/site-packages/seafile/__init__.py", line 2, in <module>
    from .rpcclient import SeafileRpcClient as RpcClient
  File "/nix/store/bbp37c848krz0lnkarypkhrsnvjr5bkz-seafile-shared-8.0.1/lib/python3.8/site-packages/seafile/rpcclient.py", line 1, in <module>
    from pysearpc import searpc_func, SearpcError, NamedPipeClient
ModuleNotFoundError: No module named 'pysearpc'

Which is not a regression as a similar error happens on master:

Traceback (most recent call last):
  File "/nix/store/pihq9hv0knyw7rvlb6cvmf91iniyva0a-seafile-shared-7.0.10/bin/.seaf-cli-wrapped", line 93, in <module>
    import urllib.request, urllib.parse, urllib.error
ImportError: No module named request

@doronbehar
Copy link
Contributor

I'm merging since this is an improvement for all packages involved, and no worse situation for seafile-shared.

@doronbehar doronbehar merged commit d9dba88 into NixOS:master Jan 5, 2021
@freezeboy
Copy link
Contributor Author

Oh sorry, didn't see this situation, but as you say, the problem seems unrelated to qt

@freezeboy freezeboy deleted the migrate-qt515 branch January 6, 2021 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants