Merged
Conversation
5a17c25 to
5a13da3
Compare
5a13da3 to
f6f786e
Compare
doronbehar
approved these changes
Jan 2, 2021
Contributor
|
DAMN. Merge conflicts, from right now. |
This allows to migrate the dependencies to python3 and qt5.15
f6f786e to
7aaadab
Compare
Contributor
Author
|
I resolved the conflict |
Contributor
|
Result of 9 packages built:
|
Contributor
|
No unfunctional executables besides: Which is not a regression as a similar error happens on master: |
Contributor
|
I'm merging since this is an improvement for all packages involved, and no worse situation for seafile-shared. |
Contributor
Author
|
Oh sorry, didn't see this situation, but as you say, the problem seems unrelated to qt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Migrate the packages without a maintainer from PR: #104474
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)