Skip to content

iannix: 0.9.20-b -> unstable-2020-12-09#106729

Merged
AndersonTorres merged 1 commit intoNixOS:masterfrom
freezeboy:update-iannix
Jan 16, 2021
Merged

iannix: 0.9.20-b -> unstable-2020-12-09#106729
AndersonTorres merged 1 commit intoNixOS:masterfrom
freezeboy:update-iannix

Conversation

@freezeboy
Copy link
Contributor

@freezeboy freezeboy commented Dec 12, 2020 •
edited
Loading

It includes a few bug fixes.
This also allows to migrate to Qt5.15

Motivation for this change

Let the package use Qt5.15 and includes a few unreleased bug fixes

Related to #104474

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@freezeboy
iannix: 0.9.20-b -> unstable-2020-12-09
ed99a16 
It includes a few bug fixes.
This also allows to migrate to Qt5.15
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Dec 12, 2020
@WolfangAukang
Copy link
Contributor

WolfangAukang commented Jan 16, 2021 •
edited
Loading

Result of nixpkgs-review pr 106729 run on x86_64-linux 1

1 package built:
  • iannix

Application working fine for me and code LGTM

@nixos-discourse
Copy link

nixos-discourse commented Jan 16, 2021

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/331

@AndersonTorres AndersonTorres merged commit d20d283 into NixOS:master Jan 16, 2021
@freezeboy freezeboy deleted the update-iannix branch January 18, 2021 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@WolfangAukang WolfangAukang WolfangAukang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@freezeboy @WolfangAukang @nixos-discourse @AndersonTorres