Skip to content

ksmoothdock: qt514 -> qt515 (fix build)#106678

Merged
doronbehar merged 1 commit intoNixOS:masterfrom
SCOTT-HAMILTON:ksmoothdock
Dec 30, 2020
Merged

ksmoothdock: qt514 -> qt515 (fix build)#106678
doronbehar merged 1 commit intoNixOS:masterfrom
SCOTT-HAMILTON:ksmoothdock

Conversation

@SCOTT-HAMILTON
Copy link
Contributor

@SCOTT-HAMILTON SCOTT-HAMILTON commented Dec 11, 2020

Motivation for this change

#104474

Things done

Patched 6.2 to build with qt515

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: documentation This PR adds or changes documentation 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Dec 11, 2020
FRidh
FRidh reviewed Dec 11, 2020
View reviewed changes
pkgs/applications/misc/ksmoothdock/default.nix Outdated
Copy link
Member

@FRidh FRidh Dec 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does this patch come from? Please use git format-patch.

Copy link
Contributor Author

@SCOTT-HAMILTON SCOTT-HAMILTON Dec 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote it

Copy link
Contributor

@doronbehar doronbehar Dec 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe contribute it upstream? Even if they won't accept it immediately, you can fetch it here.

Copy link
Contributor Author

@SCOTT-HAMILTON SCOTT-HAMILTON Dec 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done dangvd/ksmoothdock#123

Copy link
Contributor

@doronbehar doronbehar Dec 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great :) Now it would be great if you'd use fetchpatch and add a link in a comment to the PR. Also, use the following link:

https://github.com/dangvd/ksmoothdock/commit/1f4c94e289f078bdaba7bb165c5cf2a9f743076e.patch

@doronbehar doronbehar merged commit 1c090a5 into NixOS:master Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@doronbehar doronbehar doronbehar left review comments

+1 more reviewer

@FRidh FRidh FRidh left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SCOTT-HAMILTON @FRidh @doronbehar