Skip to content

krusader: Unpin qt514 -> qt515#106670

Merged
kevincox merged 1 commit intoNixOS:masterfrom
turion:dev_krusader
Dec 12, 2020
Merged

krusader: Unpin qt514 -> qt515#106670
kevincox merged 1 commit intoNixOS:masterfrom
turion:dev_krusader

Conversation

@turion
Copy link
Contributor

@turion turion commented Dec 11, 2020 •
edited
Loading

As requested in #104474

Motivation for this change

Requested in #104474

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Dec 11, 2020
@turion
Copy link
Contributor Author

turion commented Dec 12, 2020

/marvin opt-in
/status needs_reviewer

@marvin-mk2
Copy link

marvin-mk2 bot commented Dec 12, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@marvin-mk2 marvin-mk2 bot requested a review from kevincox December 12, 2020 11:56
@turion
Copy link
Contributor Author

turion commented Dec 12, 2020

Executes without crashing, seems usable

@kevincox kevincox merged commit c7469b1 into NixOS:master Dec 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevincox kevincox Awaiting requested review from kevincox

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@turion @kevincox