Skip to content

nodePackages.np: init at 7.0.0#106665

Closed
phryneas wants to merge 1 commit intoNixOS:masterfrom
phryneas:init-np
Closed

nodePackages.np: init at 7.0.0#106665
phryneas wants to merge 1 commit intoNixOS:masterfrom
phryneas:init-np

Conversation

@phryneas
Copy link
Member

Motivation for this change

np is a cli util that allows publishing to npm with additional checks compared to npm publish or yarn publish

Things done
  • Added np to node-packages.json.
  • Ran (cd pkgs/development/node-packages && ./generate.sh).
  • Built & installed the new package locally.
  • Used it locally.
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from midchildan December 11, 2020 15:35
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Dec 11, 2020
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 2, 2021

PR got combined with a few other node updates. Closing so that the update goes trough smoothly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants