Merged
Conversation
Mic92
reviewed
Dec 9, 2020
Clojure officially only supports Java LTS releases. Related to NixOS#89731. As discussed in https://discourse.nixos.org/t/package-version-arguments-vs-generic-package-arguments/9071 seems that the preferred way to set the jdk version is on `all-packages.nix`
b759cd6 to
eaa116a
Compare
Member
|
Result of 1 package failed to build:
1 package built:
|
Member
Author
|
@SuperSandro2000 lumo error can be #104190 (comment) again? |
Member
|
Result of 2 packages built:
|
Member
what architecture? |
Member
|
@GrahamcOfBorg build lumo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Clojure officially only supports Java LTS releases. Related to #89731.
As discussed in
https://discourse.nixos.org/t/package-version-arguments-vs-generic-package-arguments/9071
seems that the preferred way to set the jdk version is on
all-packages.nixThings done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)