Skip to content

clojure: use jdk11#106462

Merged
Mic92 merged 1 commit intoNixOS:masterfrom
jlesquembre:clojure-jdk11
Dec 9, 2020
Merged

clojure: use jdk11#106462
Mic92 merged 1 commit intoNixOS:masterfrom
jlesquembre:clojure-jdk11

Conversation

@jlesquembre
Copy link
Member

Motivation for this change

Clojure officially only supports Java LTS releases. Related to #89731.
As discussed in
https://discourse.nixos.org/t/package-version-arguments-vs-generic-package-arguments/9071
seems that the preferred way to set the jdk version is on
all-packages.nix

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 9, 2020
Clojure officially only supports Java LTS releases. Related to NixOS#89731.
As discussed in
https://discourse.nixos.org/t/package-version-arguments-vs-generic-package-arguments/9071
seems that the preferred way to set the jdk version is on
`all-packages.nix`
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 106462 1

1 package failed to build:
  • lumo
1 package built:
  • clojure

@jlesquembre
Copy link
Member Author

@SuperSandro2000 lumo error can be #104190 (comment) again?
As I mentioned in #102272 (comment), I think we should remove lumo sooner than later

@Mic92
Copy link
Member

Mic92 commented Dec 9, 2020

Result of nixpkgs-review pr 106462 run on x86_64-linux 1

2 packages built:
  • clojure
  • lumo

@Mic92
Copy link
Member

Mic92 commented Dec 9, 2020

Result of nixpkgs-review pr 106462 1
1 package failed to build:

* lumo

1 package built:

* clojure

what architecture?

@Mic92
Copy link
Member

Mic92 commented Dec 9, 2020

@GrahamcOfBorg build lumo

@Mic92 Mic92 merged commit 0543b71 into NixOS:master Dec 9, 2020
@jlesquembre jlesquembre deleted the clojure-jdk11 branch June 30, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants