Skip to content

openssl: 1.1.1h -> 1.1.1i #106362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Ma27 merged 1 commit into from
Dec 9, 2020
Merged

openssl: 1.1.1h -> 1.1.1i #106362

Ma27 merged 1 commit into from
Dec 9, 2020

Conversation

@mweinelt
Copy link
Member

@mweinelt mweinelt commented Dec 8, 2020 •
edited
Loading

Motivation for this change

New upstream release.
https://www.openssl.org/news/changelog.html#openssl-111

Fixing EDIPARTYNAME NULL pointer de-reference (CVE-2020-1971)
https://www.openssl.org/news/secadv/20201208.txt

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt mweinelt added 1.severity: security Issues which raise a security issue, or PRs that fix one 9.needs: port to stable A PR needs a backport to the stable release. labels Dec 8, 2020
@ajs124
Copy link
Member

ajs124 commented Dec 8, 2020

Closes #106218

ghost
ghost approved these changes Dec 8, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated my systems to 1.1.1i with the same patch and had no issues.

@ofborg ofborg bot added the 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. label Dec 8, 2020
@ofborg ofborg bot requested a review from peti December 8, 2020 17:29
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Dec 8, 2020
@Ma27 Ma27 merged commit 00a1069 into NixOS:staging Dec 9, 2020
@Ma27
Copy link
Member

Ma27 commented Dec 9, 2020

Thanks! @mweinelt would you mind porting this to staging-20.09 as well? :)

Ma27 added a commit to Ma27/nixpkgs that referenced this pull request Dec 9, 2020
@Ma27
matrix-synapse: 1.23.0 -> 1.24.0
917cac4 
ChangeLog: https://github.com/matrix-org/synapse/releases/tag/v1.24.0

This release contains two security advisories:

* CVE-2020-26257[1]: possible DDoS in the federation API.
* CVE-2020-1971[2]: to be fixed in NixOS#106362[3].

[1] https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-26257
[2] https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-1971
[3] NixOS#106362
@Ma27 Ma27 mentioned this pull request Dec 9, 2020
Merged
10 tasks
@mweinelt mweinelt deleted the openssl branch December 9, 2020 13:22
@mweinelt mweinelt mentioned this pull request Dec 9, 2020
Merged
10 tasks
Ma27 added a commit that referenced this pull request Dec 9, 2020
@Ma27
matrix-synapse: 1.23.0 -> 1.24.0
e9140b1 
ChangeLog: https://github.com/matrix-org/synapse/releases/tag/v1.24.0

This release contains two security advisories:

* CVE-2020-26257[1]: possible DDoS in the federation API.
* CVE-2020-1971[2]: to be fixed in #106362[3].

[1] https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-26257
[2] https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-1971
[3] #106362

(cherry picked from commit 917cac4)
@vcunat vcunat removed the 9.needs: port to stable A PR needs a backport to the stable release. label Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ma27 Ma27 Ma27 approved these changes

@peti peti Awaiting requested review from peti

+1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

No open projects
Staging
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mweinelt @ajs124 @Ma27 @vcunat