Skip to content

rustc: generate deterministic manifest #106284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Mic92 merged 1 commit into from
Dec 8, 2020
Merged

rustc: generate deterministic manifest #106284

Mic92 merged 1 commit into from
Dec 8, 2020

Conversation

@raboof
Copy link
Member

@raboof raboof commented Dec 7, 2020

The order of the entries in the manifest generated while installing
rustc depends on the (parallel) build, so let's sort it to make it
deterministic. Also remove install.log from the output.

Motivation for this change

Having packages be bit-for-bit reproducible makes it easier to audit
them.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@raboof raboof requested review from LnL7, Mic92 and zowoq as code owners December 7, 2020 21:31
@raboof raboof added the 6.topic: reproducible builds Run nix-build twice and get the same result. label Dec 7, 2020
@ofborg ofborg bot added the 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. label Dec 7, 2020
Mic92
Mic92 reviewed Dec 7, 2020
View reviewed changes
@ofborg ofborg bot requested review from cstrahan, globin and madjar December 7, 2020 21:41
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. labels Dec 7, 2020
@raboof @Mic92
rustc: generate deterministic manifest
b909a33 
The order of the entries in the manifest generated while installing
rustc depends on the (parallel) build, so let's sort it to make it
deterministic. Also remove install.log from the output.

Co-Authored-By: Jörg Thalheim <[email protected]>
@raboof raboof force-pushed the rustc-deterministic-manifest branch from 9068c46 to b909a33 Compare December 7, 2020 22:02
@raboof raboof changed the base branch from master to staging December 7, 2020 22:03
@Mic92
Copy link
Member

Mic92 commented Dec 8, 2020

Result of nixpkgs-review pr 106284 1

1 package built:
  • fd

@Mic92 Mic92 merged commit 650db4a into NixOS:staging Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mic92 Mic92 Mic92 left review comments

@LnL7 LnL7 Awaiting requested review from LnL7

@zowoq zowoq Awaiting requested review from zowoq

@cstrahan cstrahan Awaiting requested review from cstrahan

@globin globin Awaiting requested review from globin

@madjar madjar Awaiting requested review from madjar

+1 more reviewer

@xaverdh xaverdh xaverdh left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: reproducible builds Run nix-build twice and get the same result. 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@raboof @Mic92 @xaverdh