Skip to content

doc: Add staging workflow diagram#105986

Merged
ryantm merged 2 commits intoNixOS:masterfrom
jtojnar:staging-workflow-diagram
Dec 9, 2020
Merged

doc: Add staging workflow diagram#105986
ryantm merged 2 commits intoNixOS:masterfrom
jtojnar:staging-workflow-diagram

Conversation

@jtojnar
Copy link
Member

@jtojnar jtojnar commented Dec 5, 2020

Motivation for this change

Add diagram describing the staging workflow to Submitting changes docs. Depends on #105962

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar
Copy link
Member Author

jtojnar commented Dec 5, 2020

Rendered:

image

@ofborg ofborg bot added 8.has: documentation This PR adds or changes documentation 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Dec 5, 2020
@jtojnar jtojnar mentioned this pull request Dec 5, 2020
Merged
@Ericson2314
Copy link
Member

Ericson2314 commented Dec 6, 2020

The number of technologies that go into the this final quite remarkable :D.

@jtojnar jtojnar force-pushed the staging-workflow-diagram branch from fa7a228 to 27c6659 Compare December 8, 2020 07:57
@jtojnar jtojnar marked this pull request as ready for review December 8, 2020 07:57
@jtojnar
Copy link
Member Author

jtojnar commented Dec 8, 2020

Rebased onto master and checked that the image displays in epub too (using mupdf).

@jtojnar jtojnar requested a review from ryantm December 8, 2020 08:08
@ryantm
Copy link
Member

ryantm commented Dec 9, 2020

Result of nixpkgs-review pr 105986 1

1 package built:
  • pandoc-lua-filters

@jtojnar jtojnar force-pushed the staging-workflow-diagram branch from 27c6659 to ba11a96 Compare December 9, 2020 04:27
@jtojnar
Copy link
Member Author

jtojnar commented Dec 9, 2020

Changed pandoc-lua-filters platform to all.

ryantm
ryantm approved these changes Dec 9, 2020
View reviewed changes
Copy link
Member

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and rendering look good to me.

@ryantm ryantm merged commit bc7013c into NixOS:master Dec 9, 2020
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Dec 9, 2020
@jtojnar jtojnar deleted the staging-workflow-diagram branch December 9, 2020 16:09
@greizgh greizgh mentioned this pull request Jan 18, 2021
Merged
10 tasks
@jtojnar jtojnar mentioned this pull request Feb 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ryantm ryantm ryantm approved these changes

Assignees

No one assigned

Labels

8.has: documentation This PR adds or changes documentation 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jtojnar @Ericson2314 @ryantm